lishuxu commented on code in PR #299:
URL: https://github.com/apache/iceberg-cpp/pull/299#discussion_r2506926486
##########
src/iceberg/partition_spec.cc:
##########
@@ -48,19 +48,17 @@ PartitionSpec::PartitionSpec(std::shared_ptr<Schema>
schema, int32_t spec_id,
const std::shared_ptr<PartitionSpec>& PartitionSpec::Unpartitioned() {
static const std::shared_ptr<PartitionSpec> unpartitioned =
- std::make_shared<PartitionSpec>(
- /*schema=*/std::make_shared<Schema>(std::vector<SchemaField>{}),
kInitialSpecId,
- std::vector<PartitionField>{}, kLegacyPartitionDataIdStart - 1);
+ std::make_shared<PartitionSpec>(kInitialSpecId,
std::vector<PartitionField>{},
+ kLegacyPartitionDataIdStart - 1);
return unpartitioned;
}
-const std::shared_ptr<Schema>& PartitionSpec::schema() const { return schema_;
}
-
int32_t PartitionSpec::spec_id() const { return spec_id_; }
std::span<const PartitionField> PartitionSpec::fields() const { return
fields_; }
-Result<std::shared_ptr<StructType>> PartitionSpec::PartitionType() {
+Result<std::shared_ptr<StructType>> PartitionSpec::PartitionType(
+ std::shared_ptr<Schema> schema) {
if (fields_.empty()) {
return nullptr;
}
Review Comment:
The current implementation allows using partition_type_ cache based on
tableschema_, but the given schema parameter may belong to a different schema
version, which could lead to correctness issues.
Suggest adding schema_id to the cache key to ensure consistency.
such as:
std::unordered_map<int32_t, std::shared_ptr<StructType>>
partition_type_cache_;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
