jackylee-ch commented on code in PR #14357:
URL: https://github.com/apache/iceberg/pull/14357#discussion_r2508549817
##########
site/docs/spark-quickstart.md:
##########
@@ -309,27 +309,27 @@ If you already have a Spark environment, you can add
Iceberg, using the `--packa
=== "SparkSQL"
```sh
- spark-sql --packages org.apache.iceberg:iceberg-spark-runtime-3.5_2.12:{{
icebergVersion }}
+ spark-sql --packages org.apache.iceberg:iceberg-spark-runtime-{{
sparkVersionMajor }}:{{ icebergVersion }}
```
=== "Spark-Shell"
```sh
- spark-shell --packages
org.apache.iceberg:iceberg-spark-runtime-3.5_2.12:{{ icebergVersion }}
+ spark-shell --packages org.apache.iceberg:iceberg-spark-runtime-{{
sparkVersionMajor }}:{{ icebergVersion }}
```
=== "PySpark"
```sh
- pyspark --packages org.apache.iceberg:iceberg-spark-runtime-3.5_2.12:{{
icebergVersion }}
+ pyspark --packages org.apache.iceberg:iceberg-spark-runtime-{{
sparkVersionMajor }}:{{ icebergVersion }}
```
!!! note
If you want to include Iceberg in your Spark installation, add the Iceberg
Spark runtime to Spark's `jars` folder.
You can download the runtime by visiting to the [Releases](releases.md)
page.
<!-- markdown-link-check-disable-next-line -->
-[spark-runtime-jar]:
https://search.maven.org/remotecontent?filepath=org/apache/iceberg/iceberg-spark-runtime-3.5_2.12/{{
icebergVersion }}/iceberg-spark-runtime-3.5_2.12-{{ icebergVersion }}.jar
+[spark-runtime-jar]:
https://search.maven.org/remotecontent?filepath=org/apache/iceberg/iceberg-spark-runtime-{{
sparkVersionMajor }}/{{ icebergVersion }}/iceberg-spark-runtime-{{
sparkVersionMajor }}-{{ icebergVersion }}.jar
Review Comment:
It seems more reasonable to have the note point to the release at this
stage. Exposing the spark-runtime-jar directly might appear a bit abrupt. Can
we just remote this line?
<img width="1472" height="1028" alt="Google Chrome 2025-11-10 10 31 50"
src="https://github.com/user-attachments/assets/aeb0493a-9ade-4cc6-b09a-bf07220ae221";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
