singhpk234 commented on code in PR #14545:
URL: https://github.com/apache/iceberg/pull/14545#discussion_r2508685414


##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/TestSparkWriteConf.java:
##########
@@ -396,6 +396,37 @@ public void testSparkConfOverride() {
     }
   }
 
+  @TestTemplate
+  public void testExtraSnapshotMetadataReflectsSessionConfig() {

Review Comment:
   can we add a E2E test which verifies that when this is set the snapshot 
created actually persists the given property as snapshot property ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to