nastra commented on code in PR #14351:
URL: https://github.com/apache/iceberg/pull/14351#discussion_r2509063805
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteTablePathsAction.java:
##########
@@ -386,22 +408,23 @@ public void testDeleteDataFile() throws Exception {
.hasSize(1);
}
- @Test
+ @TestTemplate
public void testPositionDeletesParquet() throws Exception {
runPositionDeletesTest("parquet");
}
- @Test
+ @TestTemplate
public void testPositionDeletesAvro() throws Exception {
runPositionDeletesTest("avro");
}
- @Test
+ @TestTemplate
public void testPositionDeletesOrc() throws Exception {
runPositionDeletesTest("orc");
}
private void runPositionDeletesTest(String fileFormat) throws Exception {
+ assumeThat(formatVersion).isEqualTo(2);
Review Comment:
we shouldn't be skipping this for v3. Instead we need to pass the
formatVersion further below so that the right type of delete file is created
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
