wgtmac commented on code in PR #281:
URL: https://github.com/apache/iceberg-cpp/pull/281#discussion_r2512589312
##########
src/iceberg/transaction.h:
##########
@@ -42,12 +44,23 @@ class ICEBERG_EXPORT Transaction {
/// \return a new AppendFiles
virtual std::shared_ptr<AppendFiles> NewAppend() = 0;
+ /// \brief Apply multiple metadata updates to this transaction
+ ///
+ /// \param requirements the table requirements to validate
+ /// \param updates the table updates to apply
+ /// \return Status::OK if all updates were queued successfully
+ virtual Status UpdateTable(
Review Comment:
Why do we need this? I don't think `Transaction` is the entrance to create a
single update action and `Catalog` is responsible of this. Let's remove it.
##########
src/iceberg/transaction.h:
##########
@@ -42,12 +44,23 @@ class ICEBERG_EXPORT Transaction {
/// \return a new AppendFiles
virtual std::shared_ptr<AppendFiles> NewAppend() = 0;
+ /// \brief Apply multiple metadata updates to this transaction
+ ///
+ /// \param requirements the table requirements to validate
+ /// \param updates the table updates to apply
+ /// \return Status::OK if all updates were queued successfully
+ virtual Status UpdateTable(
+ const std::vector<std::unique_ptr<TableRequirement>>& requirements,
+ const std::vector<std::unique_ptr<TableUpdate>>& updates) = 0;
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
