jbonofre commented on code in PR #14560:
URL: https://github.com/apache/iceberg/pull/14560#discussion_r2514780537
##########
build.gradle:
##########
@@ -29,7 +29,6 @@ buildscript {
classpath 'com.gradleup.shadow:shadow-gradle-plugin:8.3.9'
classpath 'com.palantir.baseline:gradle-baseline-java:5.72.0'
classpath 'com.diffplug.spotless:spotless-plugin-gradle:6.25.0'
- classpath 'gradle.plugin.org.inferred:gradle-processors:3.7.0'
Review Comment:
nit: I would add just a note to explain why processors plugin can be removed.
##########
build.gradle:
##########
@@ -1024,7 +1023,8 @@ project(':iceberg-open-api') {
dependencies {
testImplementation project(':iceberg-api')
testImplementation project(':iceberg-core')
- testImplementation
project(':iceberg-core').sourceSets.test.runtimeClasspath
+ testImplementation project(path: ':iceberg-api', configuration:
'testArtifacts')
Review Comment:
I don't think `iceberg-api` is required here (`iceberg-core should be
enough).
##########
deploy.gradle:
##########
@@ -48,9 +48,6 @@ subprojects {
}
artifacts {
- archives sourceJar
Review Comment:
we have to keep `sourceJar`, `javadocJar`, and `testJar` here as it's
required to have a valid release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
