mbutrovich opened a new pull request, #1840:
URL: https://github.com/apache/iceberg-rust/pull/1840
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #1807.
## What changes are included in this PR?
<!--
Provide a summary of the modifications in this PR. List the main changes
such as new features, bug fixes, refactoring, or any other updates.
-->
Split up values.rs into component files in a values folder. Happy to discuss
organization. Here are the details to account for line differences:
1. Copyright headers duplicated - Each of the new files got its own Apache
license header
2. Module structure added - Created mod.rs with module declarations and
re-exports
3. Module-level docs added - Changed from /*! Value in iceberg */ to
individual //! style doc comments for each
module
4. Visibility changes - Changed 5 constants from `private const` to
`pub(crate) const`. This was necessary so these constants could be accessed
across the split files:
- `MAX_TIME_VALUE`
- `INT_MAX`
- `INT_MIN`
- `LONG_MAX`
- `LONG_MIN`
## Are these changes tested?
<!--
Specify what test covers (unit test, integration test, etc.).
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
