danielcweeks commented on pull request #1573: URL: https://github.com/apache/iceberg/pull/1573#issuecomment-721417229
@jackye1995 and @rdblue I created a very basic `S3URI` class to replace the `AmazonS3URI`. For now, it really makes not assumptions other than it is a valid URI and the authority equates to a bucket and path equates to key. There are some advantages to leaving this simple because there are a number of technically valid schemes (e.g. https, s3, s3a, s3n (we still have this form) and may even support signed URLs (didn't look into that). Since we're already assuming that this will only be used for S3, maybe we don't want to be too opinionated about the validation. Thoughts? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
