liurenjie1024 commented on code in PR #1827:
URL: https://github.com/apache/iceberg-rust/pull/1827#discussion_r2517770482
##########
crates/integrations/datafusion/tests/integration_datafusion_test.rs:
##########
@@ -810,3 +814,147 @@ async fn test_insert_into_nested() -> Result<()> {
Ok(())
}
+
+#[tokio::test]
+async fn test_insert_into_partitioned() -> Result<()> {
Review Comment:
I think the overall direction is to remove integration tests like this, and
move them in sqllogictests. But we could delete this after we fix #1835 .
>This test case still has its value as it validates the inserted data files
are put under the partitioned path correctly.
I'm not convinced. Such detailed check could be done in ut of low level apis
rather in integration tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
