wgtmac commented on code in PR #315:
URL: https://github.com/apache/iceberg-cpp/pull/315#discussion_r2520759723
##########
src/iceberg/manifest_writer.cc:
##########
@@ -58,13 +58,20 @@ ManifestContent ManifestWriter::content() const { return
adapter_->content(); }
Result<std::unique_ptr<Writer>> OpenFileWriter(
std::string_view location, std::shared_ptr<Schema> schema,
std::shared_ptr<FileIO> file_io,
- std::unordered_map<std::string, std::string> properties) {
- ICEBERG_ASSIGN_OR_RAISE(
- auto writer, WriterFactoryRegistry::Open(FileFormatType::kAvro,
- {.path = std::string(location),
- .schema = std::move(schema),
- .io = std::move(file_io),
- .properties =
std::move(properties)}));
+ std::unordered_map<std::string, std::string> metadata, std::string_view
schema_name) {
Review Comment:
It would be better to be format-agnostic, especially when we will introduce
Parquet as the manifest file format in V4 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
