amogh-jahagirdar commented on code in PR #14573:
URL: https://github.com/apache/iceberg/pull/14573#discussion_r2522352781
##########
core/src/main/java/org/apache/iceberg/rest/TableScanResponseParser.java:
##########
@@ -105,11 +105,11 @@ public static void serializeScanTasks(
if (fileScanTasks != null) {
gen.writeArrayFieldStart(FILE_SCAN_TASKS);
- Set<Integer> deleteFileReferences = Sets.newHashSet();
for (FileScanTask fileScanTask : fileScanTasks) {
+ Set<Integer> deleteFileReferences = Sets.newHashSet();
Review Comment:
Agree with this fix, though the worst case is that we'd have more references
than really needed for a given task right? It's not as though the wrong delete
files would be resolved if I understand right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
