liurenjie1024 commented on code in PR #1848:
URL: https://github.com/apache/iceberg-rust/pull/1848#discussion_r2522840488
##########
crates/iceberg/src/arrow/schema.rs:
##########
Review Comment:
Why we don't add test here?
##########
crates/iceberg/src/arrow/caching_delete_file_loader.rs:
##########
@@ -901,4 +986,50 @@ mod tests {
result.err()
);
}
+
+ #[tokio::test]
+ async fn test_equality_delete_with_binary_type() {
Review Comment:
It seems this test duplicate with existing test a lot, is it possible to
extend existing test with binary type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
