wgtmac commented on code in PR #313: URL: https://github.com/apache/iceberg-cpp/pull/313#discussion_r2523860515
########## README.md: ########## @@ -100,6 +100,20 @@ pre-commit install This will setup a git pre-commit-hook that is executed on each commit and will report the linting problems. To run all hooks on all files use `pre-commit run -a`. +### Dev Containers + +We provide sample Dev Container configuration files. + +To use a Dev Container as your development environment, follow the steps below, then select `Dev Containers: Reopen in Container` from VS Code's Command Palette. + +``` +cd .devcontainer +cp Dockerfile.sample Dockerfile +cp devcontainer.json.sample devcontainer.json +``` + +If you make improvements that could benefit all developers, please update the sample files and submit a pull request. Review Comment: ```suggestion If you make improvements that could benefit all developers, please update the template files and submit a pull request. ``` ########## README.md: ########## @@ -100,6 +100,20 @@ pre-commit install This will setup a git pre-commit-hook that is executed on each commit and will report the linting problems. To run all hooks on all files use `pre-commit run -a`. +### Dev Containers + +We provide sample Dev Container configuration files. Review Comment: ```suggestion We provide Dev Container configuration file templates. ``` I think template is more formal in this case. ########## README.md: ########## @@ -100,6 +100,20 @@ pre-commit install This will setup a git pre-commit-hook that is executed on each commit and will report the linting problems. To run all hooks on all files use `pre-commit run -a`. +### Dev Containers + +We provide sample Dev Container configuration files. + +To use a Dev Container as your development environment, follow the steps below, then select `Dev Containers: Reopen in Container` from VS Code's Command Palette. + +``` +cd .devcontainer +cp Dockerfile.sample Dockerfile +cp devcontainer.json.sample devcontainer.json Review Comment: ```suggestion cp Dockerfile.template Dockerfile cp devcontainer.json.template devcontainer.json ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
