emkornfield commented on code in PR #1719:
URL: https://github.com/apache/iceberg-rust/pull/1719#discussion_r2524593104
##########
crates/iceberg/src/io/object_cache.rs:
##########
@@ -118,6 +123,20 @@ impl ObjectCache {
}
}
+ /// Set a [`ManifestList`] to the cache, if duplicate key already exist,
new value will be ignored.
+ /// No-op if cache disabled.
+ pub(crate) async fn set_manifest_list(
Review Comment:
```suggestion
pub(crate) async fn cache_manifest_list(
```
nit: name bike-shedding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
