Li0k commented on code in PR #1856:
URL: https://github.com/apache/iceberg-rust/pull/1856#discussion_r2529639882
##########
crates/iceberg/src/io/file_io.rs:
##########
@@ -409,6 +418,8 @@ pub struct OutputFile {
path: String,
// Relative path of file to uri, starts at [`relative_path_pos`]
relative_path_pos: usize,
+ // Whether to use append mode for writes (required for some storage
backends like AZDLS)
+ append_file: bool,
Review Comment:
Thanks a lot for your comment. Using bool is indeed not a good practice. Let
me refactor it to Enum. However, I'm not sure if we should expose this
parameter externally for now, because in the bug I encountered, only AZDLS uses
it, and this is related to opendal's implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
