singhpk234 commented on code in PR #14600:
URL: https://github.com/apache/iceberg/pull/14600#discussion_r2532914744
##########
api/src/main/java/org/apache/iceberg/UpdateSchema.java:
##########
@@ -659,4 +659,15 @@ default UpdateSchema setIdentifierFields(String... names) {
default UpdateSchema caseSensitive(boolean caseSensitive) {
throw new UnsupportedOperationException();
}
+
+ /**
+ * Rollback table's schema to a specific {@link Schema} identified by id.
+ *
+ * @param schemaId schema id to roll back table to.
+ * @return this for method chaining
+ * @throws IllegalArgumentException If the table has no schema with the
given id
+ */
+ default UpdateSchema rollbackTo(int schemaId) {
+ throw new UnsupportedOperationException();
+ }
Review Comment:
per this particular comment :
https://github.com/apache/iceberg/issues/5591#issuecomment-1222524262
Seems like its intention not to rollback to prev schema, any reason why it
ok to do it now ?
It has a possible mitigation for undelete with required column by read
defaults mentioned, any reason why this over that ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
