tmater commented on code in PR #14588:
URL: https://github.com/apache/iceberg/pull/14588#discussion_r2536775047
##########
parquet/src/main/java/org/apache/iceberg/parquet/RemoveIds.java:
##########
@@ -77,6 +77,16 @@ public Type primitive(PrimitiveType primitive) {
.named(primitive.getName());
}
+ @Override
+ public Type variant(GroupType variant) {
+ Types.GroupBuilder<GroupType> builder =
+
Types.buildGroup(variant.getRepetition()).as(variant.getLogicalTypeAnnotation());
+ for (Type field : variant.getFields()) {
+ builder.addField(field);
Review Comment:
The typed_value field and all variant's nested children are created without
field IDs in
[TypeToMessageType.java](https://github.com/apache/iceberg/blob/main/parquet/src/main/java/org/apache/iceberg/parquet/TypeToMessageType.java#L166).
Only the variant group itself gets an id, so they all have field_id=-1 by
default.
Is there a plan to add field IDs to the variant's internal structure in the
future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
