manuzhang commented on code in PR #14155:
URL: https://github.com/apache/iceberg/pull/14155#discussion_r2536877760
##########
spark/v4.1/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala:
##########
@@ -124,10 +124,10 @@ case class ResolveViews(spark: SparkSession) extends
Rule[LogicalPlan] with Look
private def rewriteIdentifiers(
plan: LogicalPlan,
catalogAndNamespace: Seq[String]): LogicalPlan = {
- // Substitute CTEs and Unresolved Ordinals within the view, then rewrite
unresolved functions and relations
+ // Rewrite unresolved functions and relations
qualifyTableIdentifiers(
qualifyFunctionIdentifiers(
- SubstituteUnresolvedOrdinals.apply(CTESubstitution.apply(plan)),
+ CTESubstitution.apply(plan),
Review Comment:
`SubstituteUnresolvedOrdinals` removed and not needed after
https://github.com/apache/spark/pull/50606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
