nastra commented on code in PR #13400:
URL: https://github.com/apache/iceberg/pull/13400#discussion_r2538835097


##########
core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java:
##########
@@ -156,6 +159,52 @@ public abstract class CatalogTests<C extends Catalog & 
SupportsNamespaces> {
           .withRecordCount(2) // needs at least one record or else metrics 
will filter it out
           .build();
 
+  // Delete files for testing
+  protected static final DeleteFile FILE_A_DELETES =

Review Comment:
   I don't think any other subclass of `CatalogTests` use these, so maybe they 
should be moved to the REST tests?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to