singhpk234 commented on code in PR #13400:
URL: https://github.com/apache/iceberg/pull/13400#discussion_r2539385812
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -163,9 +179,19 @@ public <T extends RESTResponse> T execute(
Object body = roundTripSerialize(request.body(), "request");
HTTPRequest req =
ImmutableHTTPRequest.builder().from(request).body(body).build();
T response = super.execute(req, responseType, errorHandler,
responseHeaders);
+ if (response instanceof BaseScanTaskResponse) {
+ // This is for the case where the response does not roundTrip
Review Comment:
I removed it, it was basically there to skip serde of the response because
it required setting parserContext to the mapper unfortunately we intialize a
MAPPER inside the TestRESTCatalog which skips the entire handling we have for
parserContext inside the HTTPClient, so what i did was mimicked what we are
doing there and setting injectable value to provide the mapper the context to
deserialize using the ParserContext, though ideal would be testing stuff E2E
using the existing mapper
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
