danielcweeks commented on PR #14501: URL: https://github.com/apache/iceberg/pull/14501#issuecomment-3549604019
> When you call trash.isEnabled(), it checks whether the TrashPolicy.isEnabled(), and in the TrashPolicyDefault, isEnabled() ensures that the deletion interval is > 0. So I think this may be a non issue. If people override their trash class to be something else, it could be an issue. The issue is that the config can be different for the client than for the NameNode. So if a client configures `interval > 0`, but the NameNode does not have that config, then a client will move data files, but they will never be cleaned up. > I'm less sure what you mean on this one. We aren't making this change in the s3 file IO, but I'm less familiar with the differences between that and s3a. HadoopFileIO is an abstraction for all Hadoop FileSystem implementations (DistributedFileSystem, S3AFileSystem, GCSFileSystem, etc.). That means that if I enable this in `core-side.xml` and use a `s3` mapped scheme, I would trigger the move behavior, which I don't think we want for non HDFS file systems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
