jnagel12 commented on code in PR #629:
URL: https://github.com/apache/iceberg-go/pull/629#discussion_r2539763461
##########
view/view.go:
##########
@@ -18,234 +18,156 @@
package view
import (
+ "context"
"encoding/json"
"errors"
"fmt"
- "iter"
"slices"
- "strings"
"github.com/apache/iceberg-go"
+ "github.com/apache/iceberg-go/internal"
+ "github.com/apache/iceberg-go/io"
+ "github.com/apache/iceberg-go/table"
+ "github.com/google/uuid"
)
-var (
- ErrInvalidViewMetadata = errors.New("invalid view
metadata")
- ErrInvalidViewMetadataFormatVersion = errors.New("invalid or missing
format-version in view metadata")
-)
-
-// Metadata defines the format for view metadata,
-// similar to how Iceberg supports a common table format for tables
-type Metadata interface {
Review Comment:
moved to `metadata.go`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]