rdblue commented on code in PR #14533: URL: https://github.com/apache/iceberg/pull/14533#discussion_r2539865778
########## core/src/main/java/org/apache/iceberg/InheritableTrackedMetadata.java: ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.io.Serializable; + +/** + * Interface for applying inheritable metadata to tracked file entries in V4 manifests. + * + * <p>Similar to {@link InheritableMetadata} but for V4 TrackedFile entries. + */ +interface InheritableTrackedMetadata extends Serializable { + /** + * Apply inheritable metadata to a tracked file entry. + * + * @param entry the tracked file entry + * @return the entry with metadata applied + */ + TrackedFile<?> apply(TrackedFile<?> entry); Review Comment: This should either be `GenericTrackedFile` (the internal representation) or an interface in core, like `TrackedFileSetters`. I would probably use `GenericTrackedFile`. I think we also need to consider what setter methods to add here. We have inverted the relationship between `TrackedFile` / `DataFile` and `TrackingInfo` / `ManifestEntry` so I don't think it makes sense to call `setSnapshotId` on `TrackedFile` itself just because that is the top-level record in manifests. I'd rather get the `TrackingInfo` and modify that directly: ```java TrackedFile apply(GenericTrackedFile file) { TrackingInfoStruct info; if (file.trackingInfo() instanceof TrackingInfoStruct) { info = file.trackingInfo(); } else { info = new TrackingInfoStruct(file.trackingInfo()); // copy to mutable } if (info.snapshotId() == null) { info.setSnapshotId(snapshotId); } ... file.setTrackingInfo(info); return file; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
