CTTY commented on issue #1868: URL: https://github.com/apache/iceberg-rust/issues/1868#issuecomment-3550005638
Hi @jembishop , thanks for raising this! I think it's a legit bug you've found: we should rely on table version id for occ: https://iceberg.apache.org/docs/latest/aws/#optimistic-locking [Your fix](https://github.com/apache/iceberg-rust/compare/main...jembishop:iceberg-rust:version_fix) looks correct to me as well. I'd suggest add a new method `async load_table_with_version_id(&self, table: &TableIdent) -> Result<(Table, Option<&str>)>` and have `load_table` reuse the new method Please let me know if you'd like to raise a PR, thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
