rambleraptor commented on code in PR #14266:
URL: https://github.com/apache/iceberg/pull/14266#discussion_r2543416724
##########
core/src/main/java/org/apache/iceberg/schema/UnionByNameVisitor.java:
##########
@@ -204,7 +222,8 @@ private boolean isIgnorableTypeUpdate(Type existingType,
Type newType) {
// existingType:long -> newType:int returns true, meaning it is ignorable
// existingType:int -> newType:long returns false, meaning it is not
ignorable
return newType.isPrimitiveType()
- && TypeUtil.isPromotionAllowed(newType,
existingType.asPrimitiveType());
+ && TypeUtil.isPromotionAllowed(
+ newType, existingType.asPrimitiveType(), formatVersion, false);
Review Comment:
Added comment to name this parameter.
We haven't had a need to plumb through if this field is referenced by
source-id and I didn't think it was necessary. Might've been a poor assumption?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
