danielcweeks commented on code in PR #14447:
URL: https://github.com/apache/iceberg/pull/14447#discussion_r2543644070
##########
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryMetastoreCatalog.java:
##########
@@ -89,12 +93,8 @@ public void initialize(String name, Map<String, String>
properties) {
this.projectId = properties.get(PROJECT_ID);
this.projectLocation = properties.getOrDefault(GCP_LOCATION,
DEFAULT_GCP_LOCATION);
- BigQueryOptions options =
- BigQueryOptions.newBuilder()
- .setProjectId(projectId)
- .setLocation(projectLocation)
- .setRetrySettings(ServiceOptions.getDefaultRetrySettings())
- .build();
+ BigQueryClientFactory clientFactory = createClientFactory(properties);
Review Comment:
@joyhaldar I'm concerned about this approach because it doesn't really make
sense to me. What we appear to be introducing is nominally called
`BigQueryClientFactory` but the factory is not producing clients, rather just
some configuration settings to configure the client based on a different set of
options using the same builder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
