emkornfield commented on code in PR #1851:
URL: https://github.com/apache/iceberg-rust/pull/1851#discussion_r2543692262
##########
crates/iceberg/src/spec/table_properties.rs:
##########
@@ -16,21 +16,25 @@
// under the License.
use std::collections::HashMap;
+use std::fmt::Display;
+use std::str::FromStr;
+
+use crate::error::{Error, ErrorKind};
// Helper function to parse a property from a HashMap
// If the property is not found, use the default value
-fn parse_property<T: std::str::FromStr>(
Review Comment:
this is cleanup because it sounds like the crate's errors are preferred I
can revert this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
