zhjwpku commented on code in PR #327: URL: https://github.com/apache/iceberg-cpp/pull/327#discussion_r2545294218
########## src/iceberg/expression/evaluator.cc: ########## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#include "iceberg/expression/evaluator.h" + +#include "iceberg/expression/binder.h" +#include "iceberg/expression/expression_visitor.h" +#include "iceberg/schema.h" +#include "iceberg/util/macros.h" + +namespace iceberg { + +class Evaluator::EvalVisitor : public BoundVisitor<bool> { + public: + void UpdateRow(const StructLike* row) { row_ = row; } Review Comment: nit: SetRow? since this method doesn't update anything. ########## src/iceberg/expression/evaluator.cc: ########## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#include "iceberg/expression/evaluator.h" + +#include "iceberg/expression/binder.h" +#include "iceberg/expression/expression_visitor.h" +#include "iceberg/schema.h" +#include "iceberg/util/macros.h" + +namespace iceberg { + +class Evaluator::EvalVisitor : public BoundVisitor<bool> { + public: + void UpdateRow(const StructLike* row) { row_ = row; } + + Result<bool> AlwaysTrue() override { return true; } + + Result<bool> AlwaysFalse() override { return false; } + + Result<bool> Not(bool child_result) override { return !child_result; } + + Result<bool> And(bool left_result, bool right_result) override { + return left_result && right_result; + } + + Result<bool> Or(bool left_result, bool right_result) override { + return left_result || right_result; + } + + Result<bool> IsNull(const std::shared_ptr<BoundTerm>& term) override { + ICEBERG_DCHECK(row_, "Row is not set"); + ICEBERG_ASSIGN_OR_RAISE(auto value, term->Evaluate(*row_)); + return value.IsNull(); + } + + Result<bool> NotNull(const std::shared_ptr<BoundTerm>& term) override { + ICEBERG_DCHECK(row_, "Row is not set"); Review Comment: Not a strong opinion, we could adopt the same pattern used for Eq/NotEq, where NotXXX calls XXX and returns !result. Ditto for Lt/GtEq and Gt/LtEq. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
