amogh-jahagirdar commented on code in PR #13186:
URL: https://github.com/apache/iceberg/pull/13186#discussion_r2546962961
##########
azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java:
##########
@@ -124,6 +129,13 @@ public AzureProperties(Map<String, String> properties) {
PropertyUtil.propertyAsBoolean(properties,
ADLS_REFRESH_CREDENTIALS_ENABLED, true);
this.token = properties.get(ADLS_TOKEN);
this.allProperties = SerializableMap.copyOf(properties);
+ if (properties.containsKey(KEYVAULT_URI)) {
+ this.keyVaultUri = properties.get(KEYVAULT_URI);
+ }
Review Comment:
Minor: could you add a newline after the if (general practice in the project
to separate the if block and the next statement)
##########
azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java:
##########
@@ -48,6 +49,8 @@ public class AzureProperties implements Serializable {
public static final String ADLS_SHARED_KEY_ACCOUNT_NAME =
"adls.auth.shared-key.account.name";
public static final String ADLS_SHARED_KEY_ACCOUNT_KEY =
"adls.auth.shared-key.account.key";
public static final String ADLS_TOKEN = "adls.token";
+ public static final String KEYVAULT_URI = "keyvault.uri";
Review Comment:
Would be good to get @kevinjqliu input here as well.
##########
azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java:
##########
@@ -48,6 +49,8 @@ public class AzureProperties implements Serializable {
public static final String ADLS_SHARED_KEY_ACCOUNT_NAME =
"adls.auth.shared-key.account.name";
public static final String ADLS_SHARED_KEY_ACCOUNT_KEY =
"adls.auth.shared-key.account.key";
public static final String ADLS_TOKEN = "adls.token";
+ public static final String KEYVAULT_URI = "keyvault.uri";
Review Comment:
I would agree that we should have a prefix indicating that this is azure
specific and that this is independent from ADLS. Could we make this
`azure.keyvault.uri` as suggested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
