rdblue commented on a change in pull request #1722:
URL: https://github.com/apache/iceberg/pull/1722#discussion_r518307981
##########
File path: api/src/main/java/org/apache/iceberg/expressions/Expressions.java
##########
@@ -120,7 +120,7 @@ public static Expression not(Expression child) {
}
public static <T> UnboundPredicate<T> notNull(UnboundTerm<T> expr) {
- return new UnboundPredicate<>(Expression.Operation.IS_NULL, expr);
+ return new UnboundPredicate<>(Expression.Operation.NOT_NULL, expr);
Review comment:
I don't see any uses of this factory method in Spark, Flink, or MR/Hive
so luckily, I don't think that this affects engines. (And I would expect it to
be caught quickly by Spark tests if we did.) I think that decreases the urgency
of this fix, but it still affects API users.
Thanks for catching this, @yyanyy!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
