rdblue commented on a change in pull request #1618:
URL: https://github.com/apache/iceberg/pull/1618#discussion_r518314591
##########
File path: flink/src/main/java/org/apache/iceberg/flink/CatalogLoader.java
##########
@@ -45,12 +45,22 @@
*/
Catalog loadCatalog();
- static CatalogLoader hadoop(String name, Configuration hadoopConf, String
warehouseLocation) {
- return new HadoopCatalogLoader(name, hadoopConf, warehouseLocation);
+ static CatalogLoader hadoop(
+ String name,
+ Configuration hadoopConf,
+ String warehouseLocation,
+ Map<String, String> properties) {
+ return new HadoopCatalogLoader(name, hadoopConf, warehouseLocation,
properties);
Review comment:
You're right. Since these are package-private, I don't think we need to
maintain them. I was thinking that people would call these from the public API
to configure the source and sink builders, but these aren't public.
We may still want to keep them to avoid changing lots of files in this PR,
and I still think it is a good idea to pull out the config here, rather than in
`FlinkCatalogFactory` because we want to move toward catalogs interpreting
their own property maps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
