dingo4dev commented on PR #2768: URL: https://github.com/apache/iceberg-python/pull/2768#issuecomment-3561140655
> LGTM! > > Should we also look to add this in the precommit configs? > > https://github.com/apache/iceberg-python/blob/93a4173eaac7163c6b1a9cc1eae02b25bbdf317c/.pre-commit-config.yaml#L35-L45 @kevinjqliu I added and tried this, any I found it not compactible with mypy https://github.com/apache/iceberg-python/actions/runs/19558312158/job/56005297343#step:7:60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
