wgtmac commented on code in PR #337:
URL: https://github.com/apache/iceberg-cpp/pull/337#discussion_r2548678053
##########
CMakeLists.txt:
##########
@@ -45,6 +45,21 @@ option(ICEBERG_BUILD_REST "Build rest catalog client" ON)
option(ICEBERG_ENABLE_ASAN "Enable Address Sanitizer" OFF)
option(ICEBERG_ENABLE_UBSAN "Enable Undefined Behavior Sanitizer" OFF)
+if(ICEBERG_BUILD_SHARED)
+ set(ICEBERG_TEST_LINKAGE_DEFAULT "shared")
+else()
+ set(ICEBERG_TEST_LINKAGE_DEFAULT "static")
+endif()
+set(ICEBERG_TEST_LINKAGE ${ICEBERG_TEST_LINKAGE_DEFAULT} CACHE STRING "Linkage
of Iceberg libraries with unit tests executables")
+if(ICEBERG_BUILD_TESTS)
+ if(ICEBERG_TEST_LINKAGE STREQUAL "shared" AND NOT ICEBERG_BUILD_SHARED)
+ message(FATAL_ERROR "If using ICEBERG_TEST_LINKAGE=shared, must also pass
ICEBERG_BUILD_SHARED=on")
Review Comment:
```suggestion
message(FATAL_ERROR "If using ICEBERG_TEST_LINKAGE=shared, must also
pass ICEBERG_BUILD_SHARED=ON")
```
##########
CMakeLists.txt:
##########
@@ -45,6 +45,21 @@ option(ICEBERG_BUILD_REST "Build rest catalog client" ON)
option(ICEBERG_ENABLE_ASAN "Enable Address Sanitizer" OFF)
option(ICEBERG_ENABLE_UBSAN "Enable Undefined Behavior Sanitizer" OFF)
+if(ICEBERG_BUILD_SHARED)
+ set(ICEBERG_TEST_LINKAGE_DEFAULT "shared")
+else()
+ set(ICEBERG_TEST_LINKAGE_DEFAULT "static")
+endif()
+set(ICEBERG_TEST_LINKAGE ${ICEBERG_TEST_LINKAGE_DEFAULT} CACHE STRING "Linkage
of Iceberg libraries with unit tests executables")
+if(ICEBERG_BUILD_TESTS)
+ if(ICEBERG_TEST_LINKAGE STREQUAL "shared" AND NOT ICEBERG_BUILD_SHARED)
+ message(FATAL_ERROR "If using ICEBERG_TEST_LINKAGE=shared, must also pass
ICEBERG_BUILD_SHARED=on")
+ endif()
+ if(ICEBERG_TEST_LINKAGE STREQUAL "static" AND NOT ICEBERG_BUILD_STATIC)
+ message(FATAL_ERROR "If using ICEBERG_TEST_LINKAGE=static, must also pass
ICEBERG_BUILD_STATIC=on")
Review Comment:
```suggestion
message(FATAL_ERROR "If using ICEBERG_TEST_LINKAGE=static, must also
pass ICEBERG_BUILD_STATIC=ON")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
