HuaHuaY commented on code in PR #338:
URL: https://github.com/apache/iceberg-cpp/pull/338#discussion_r2548889943
##########
cmake_modules/IcebergBuildUtils.cmake:
##########
@@ -152,6 +152,10 @@ function(add_iceberg_lib LIB_NAME)
string(TOUPPER ${LIB_NAME} VISIBILITY_NAME)
target_compile_definitions(${LIB_NAME}_shared PRIVATE
${VISIBILITY_NAME}_EXPORTING)
+ set_target_properties(${LIB_NAME}_shared
Review Comment:
I follow the cmakelist of parquet.
https://github.com/apache/arrow/blob/main/cpp/CMakeLists.txt#L569
I'm not sure whether it's useful to import such an option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
