szlta commented on code in PR #14645:
URL: https://github.com/apache/iceberg/pull/14645#discussion_r2549245467
##########
core/src/test/java/org/apache/iceberg/puffin/TestPuffinWriter.java:
##########
@@ -86,6 +91,21 @@ public void testWriteMetricDataCompressedZstd() throws
Exception {
testWriteMetric(ZSTD, "v1/sample-metric-data-compressed-zstd.bin");
}
+ @Test
+ public void testEncryptedLength() throws Exception {
Review Comment:
Sure, adding an encrypted and an unencrypted case makes sense. Thanks for
pointing to `TestGcmStreams`, I got some insipration from there on creating
real encrypted stream instead of a mock one.
Now I have a parameterized test that has no mock and tests both cases. I
don't think there's a need to add anything into `TestGcmStreams` though, we're
not testing any stream here, the class under test is just `PuffinWriter`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
