tmater opened a new pull request, #14653: URL: https://github.com/apache/iceberg/pull/14653
## Summary Switch `ViewCatalogTests` to use `RewriteTablePathUtil` for path construction instead of `java.nio.file.Paths`. This change introduces helper methods `warehouseLocation()` and `locationPath()` to centralize and simplify URI-based path handling in tests. ## Background The previous implementation used `java.nio.file.Paths.get()` to construct file paths in tests. This approach has a critical limitation: `Paths.get()` relies on the default filesystem provider and can corrupt URI schemes when working with URI strings (e.g., `file://`, `s3://`, `gs://`). This issue appeared in Apache Polaris when these tests are used with cloud storage: https://github.com/apache/polaris/pull/3095 ## Changes - Replaced `java.nio.file.Paths` with `RewriteTablePathUtil.combinePaths()` for path construction - Added `warehouseLocation()` helper method to get the base warehouse URI - Added `locationPath(String... pathSegments)` helper method to combine path segments with the warehouse location - Simplified all test path construction calls, removing nested `Paths.get()` invocations -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
