pvary commented on code in PR #12298:
URL: https://github.com/apache/iceberg/pull/12298#discussion_r2550318069


##########
core/src/main/java/org/apache/iceberg/RewriteTablePathUtil.java:
##########
@@ -528,6 +528,18 @@ private static DeleteFile newEqualityDeleteEntry(
   public interface PositionDeleteReaderWriter extends Serializable {
     CloseableIterable<Record> reader(InputFile inputFile, FileFormat format, 
PartitionSpec spec);
 
+    default PositionDeleteWriter<Record> writer(
+        OutputFile outputFile, FileFormat format, PartitionSpec spec, 
StructLike partition)
+        throws IOException {
+      return writer(outputFile, format, spec, partition, null);
+    }
+
+    /**
+     * @deprecated This method is deprecated as of version 1.11.0 and will be 
removed in 1.12.0.
+     *     Position deletes that include row data are no longer supported. Use 
{@link
+     *     #writer(OutputFile, FileFormat, PartitionSpec, StructLike)} instead.
+     */
+    @Deprecated

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to