smaheshwar-pltr commented on code in PR #14659:
URL: https://github.com/apache/iceberg/pull/14659#discussion_r2553284309
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -148,13 +148,15 @@ public EncryptionManager encryption() {
if (tableKeyId != null) {
if (keyManagementClient == null) {
throw new RuntimeException(
- "Cant create encryption manager, because key management client is
not set");
+ "Cannot create encryption manager without a key management
client");
}
- Map<String, String> encryptionProperties = Maps.newHashMap();
- encryptionProperties.put(TableProperties.ENCRYPTION_TABLE_KEY,
tableKeyId);
- encryptionProperties.put(
- TableProperties.ENCRYPTION_DEK_LENGTH,
String.valueOf(encryptionDekLength));
+ Map<String, String> encryptionProperties =
+ ImmutableMap.of(
Review Comment:
In https://github.com/apache/iceberg/pull/13225, I felt like
`ImmutableMap.of` would be more natural here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
