smaheshwar-pltr commented on code in PR #13225:
URL: https://github.com/apache/iceberg/pull/13225#discussion_r2553289469
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableOperations.java:
##########
@@ -241,12 +328,38 @@ private static Long
expectedSnapshotIdIfSnapshotAddOnly(List<MetadataUpdate> upd
return addedSnapshotId;
}
+ private void encryptionPropsFromMetadata(TableMetadata metadata) {
+ if (metadata == null || metadata.properties() == null) {
+ return;
+ }
+
+ encryptedKeysFromMetadata = metadata.encryptionKeys();
+
+ Map<String, String> tableProperties = metadata.properties();
+ if (tableKeyId == null) {
Review Comment:
Could be wrong, but I understood @huaxingao's comment as asking whether we
should re-fetch encryption-related properties from the catalog on refresh /
commit.
I believe we don't need to, and that's aligned with not updating configs on
refresh / commit in this class prior to this PR. The key rotation case should
even be fine because it'll generally keep the ID the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
