okumin opened a new pull request, #14671: URL: https://github.com/apache/iceberg/pull/14671
RCKUtils lists all namespaces used in the integration test suite. The list is used for two purposes: (1) [the reference integration tests](https://github.com/apache/iceberg/blob/8b55ac834015ce664f879ecfe1e80a941a994420/open-api/src/test/java/org/apache/iceberg/rest/RESTCompatibilityKitCatalogTests.java#L43-L45) assert those namespaces don't exist at the beginning and (2) [RCKUtils.purgeCatalogTestEntries](https://github.com/apache/iceberg/blob/8b55ac834015ce664f879ecfe1e80a941a994420/open-api/src/testFixtures/java/org/apache/iceberg/rest/RCKUtils.java#L126-L139) removes them. Since the current list is not comprehensive, `RCKUtils.purgeCatalogTestEntries` is also incomplete. For example, when we run [CatalogTests#testRegisterExistingTable](https://github.com/apache/iceberg/blob/8b55ac834015ce664f879ecfe1e80a941a994420/core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java#L3151-L3168) twice against a REST catalog process, the test case fails unless we additionally clean up namespaces or fully recreate the REST server resource. I have some options here. - (1) Maintain the list of tested namespaces - (2) Let RCKUtils.purgeCatalogTestEntries purge all namespaces - (3) Or else? I drafted this PR with the first option, which is likely the most consistent with the existing implementation. The biggest drawback is that it's too easy to make the list obsolete again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
