kumarpritam863 commented on code in PR #14672:
URL: https://github.com/apache/iceberg/pull/14672#discussion_r2554894604
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/Committer.java:
##########
@@ -19,39 +19,18 @@
package org.apache.iceberg.connect;
import java.util.Collection;
-import org.apache.iceberg.catalog.Catalog;
import org.apache.kafka.common.TopicPartition;
import org.apache.kafka.connect.sink.SinkRecord;
import org.apache.kafka.connect.sink.SinkTaskContext;
public interface Committer {
Review Comment:
This might look like backward incompatible change but as this config option
to plug committer is not there it is very highly likely that users are using
the CommitterImpl by default and this is the right time to change these API's
and make this sensible and in sync with the Connect Task terminologies. Also
this helps us prevent the current hacks and edge cases like using isInitialized
to check multiple times and at multiple places to avoid having null pointer
exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
