zhjwpku commented on code in PR #317:
URL: https://github.com/apache/iceberg-cpp/pull/317#discussion_r2556574258
##########
src/iceberg/v3_metadata.cc:
##########
@@ -189,7 +188,12 @@ Status ManifestFileAdapterV3::Init() {
return ToArrowSchema(*manifest_list_schema_, &schema_);
}
-Status ManifestFileAdapterV3::Append(const ManifestFile& file) {
+Status ManifestFileAdapterV3::Append(ManifestFile& file) {
+ // TODO(zhjwpku): Should we set sequence_number/first_row_id here?
Review Comment:
These TODOs were meant to attract reviewers' closer attention. I've removed
them now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
