singhpk234 commented on code in PR #14462:
URL: https://github.com/apache/iceberg/pull/14462#discussion_r2558393762
##########
core/src/main/java/org/apache/iceberg/expressions/ExpressionParser.java:
##########
@@ -236,11 +264,28 @@ private String operationType(Expression.Operation op) {
private void term(Term term) throws IOException {
if (term instanceof UnboundTransform) {
UnboundTransform<?, ?> transform = (UnboundTransform<?, ?>) term;
- transform(transform.transform().toString(), transform.ref().name());
+ NamedReference<?> ref = transform.ref();
+ Integer fieldId = null;
+ if (mode == SerializationMode.WITH_FIELD_IDS && ref instanceof
IDReference) {
Review Comment:
This mostly for the mode where even if we have IDs we still prefer the named
reference in the serde ? wdyt of this use case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
