kevinjqliu commented on code in PR #14684:
URL: https://github.com/apache/iceberg/pull/14684#discussion_r2561038302


##########
.github/workflows/open-api.yml:
##########
@@ -42,10 +42,9 @@ jobs:
 
     steps:
       - uses: actions/checkout@v4
-      - uses: actions/setup-python@v5
-        with:
-          python-version: 3.9

Review Comment:
   dont need to specify python version, uv will do this. 



##########
.github/workflows/open-api.yml:
##########
@@ -57,6 +56,3 @@ jobs:
       - name: Check if code is up to date
         working-directory: ./open-api
         run: git diff --exit-code
-      - name: Validate S3 REST Signer spec
-        working-directory: ./aws/src/main/resources
-        run: openapi-spec-validator s3-signer-open-api.yaml

Review Comment:
   move to `make lint` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to