rdblue commented on a change in pull request #1716:
URL: https://github.com/apache/iceberg/pull/1716#discussion_r518927434
##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/ParquetReader.java
##########
@@ -135,11 +135,9 @@ private void advance() {
throw new RuntimeIOException(e);
}
- long rowPosition = rowGroupsStartRowPos[nextRowGroup];
+ model.setPageSource(pages, rowGroupsStartRowPos == null ? 0 :
rowGroupsStartRowPos[nextRowGroup]);
Review comment:
I don't think this file should change. If the determination not to use
correct start positions in made in `ReadConf`, then it should just set the
position to 0 there. This can use whatever `rowGroupStartRowPos` contains.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
