HuaHuaY commented on code in PR #296:
URL: https://github.com/apache/iceberg-cpp/pull/296#discussion_r2563758099
##########
src/iceberg/catalog/rest/constant.h:
##########
@@ -28,17 +28,16 @@
namespace iceberg::rest {
-constexpr std::string_view kHeaderContentType = "Content-Type";
-constexpr std::string_view kHeaderAccept = "Accept";
-constexpr std::string_view kHeaderXClientVersion = "X-Client-Version";
-constexpr std::string_view kHeaderUserAgent = "User-Agent";
+inline const std::string kHeaderContentType = "Content-Type";
Review Comment:
So @HeartLinked may need to remove `std::string(...)` wrapper in some files,
such as `src/iceberg/catalog/rest/config.cc`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
