aokolnychyi commented on PR #14155:
URL: https://github.com/apache/iceberg/pull/14155#issuecomment-3584374982
I went through the changes and they look good to me.
A few remaining points:
- Remaining failing tests.
- What shall we do with Comet?
- I want to test more of the MERGE behavior changes in Spark to make sure
they are correct.
Like here, for instance, it seems suspicious that we now allow strings to be
implicitly casted to int.
```
assertThatThrownBy(
() ->
sql(
"MERGE INTO %s t USING source s "
+ "ON t.id == s.c1 "
+ "WHEN MATCHED THEN "
+ " UPDATE SET t.s.n1 = s.c3",
commitTarget()))
.isInstanceOf(AnalysisException.class)
.hasMessageContaining("Cannot safely cast `s`.`n1` \"STRING\" to
\"INT\".");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
