davseitsev commented on PR #12892: URL: https://github.com/apache/iceberg/pull/12892#issuecomment-3586044395
Hi @pvary, thanks for checking in. I’ve just pushed the last small changes, and from my side the PR is now up to date. The production changes are relatively small; most of the diff is in tests (CatalogTests and Spark tests), and I’ve addressed all comments from you and @nastra. I also dropped the REST catalog tests for unique-table-location after your review, as RESTServerExtension is not easily configurable. This PR doesn’t wire unique-table-location through the REST catalog yet, and I think that deserves a separate discussion and follow-up PR, so excluding those tests for now seemed the least confusing option. So as long as you don’t have any further comments, I consider this ready for another look / for merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
