wgtmac commented on code in PR #358:
URL: https://github.com/apache/iceberg-cpp/pull/358#discussion_r2570367680
##########
src/iceberg/pending_update.h:
##########
@@ -72,6 +75,30 @@ class ICEBERG_EXPORT PendingUpdate {
/// Apply() can be used to validate and inspect the uncommitted changes before
/// committing. Commit() applies the changes and commits them to the table.
///
+/// Error Collection Pattern:
Review Comment:
Perhaps we can make it a separate class so that other builders can leverage
this as well? For example, TableMetadataBuilder uses the same pattern:
https://github.com/apache/iceberg-cpp/blob/main/src/iceberg/table_metadata.cc#L279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
