mimaison commented on code in PR #14682:
URL: https://github.com/apache/iceberg/pull/14682#discussion_r2572168009


##########
kafka-connect/kafka-connect-runtime/src/integration/java/org/apache/iceberg/connect/KafkaConnectUtils.java:
##########
@@ -54,10 +54,6 @@ public String getName() {
       return name;
     }
 
-    public Map<String, Object> getConfig() {

Review Comment:
   I did not see `KafkaConnectUtils` in the 
[Javadoc](https://iceberg.apache.org/javadoc/nightly/), so I assumed it was not 
part of the public API and did not need a deprecation. 
   
   Anyway this change is the reason the tests are broken, it turns out this 
method is required.
   
   I've reverted this change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to